Conversation
…eting a specific service instance When `service` is set and doesn't match, the service forwards the frame instead of consuming it. This allows targeting a specific service when multiple services of the same type exist in the pipeline.
| # directly. The frame.delta path falls through to super, which calls | ||
| # _update_settings → our override handles the rest. | ||
| if isinstance(frame, LLMUpdateSettingsFrame) and frame.delta is None: | ||
| if ( |
There was a problem hiding this comment.
not sure we even strictly need to update this file, as the service is deprecated...we could just have it not support the new service targeting field...
There was a problem hiding this comment.
actually tempted to do that, just to avoid having to test this stuff...what do y'all think?
There was a problem hiding this comment.
Yes, I would not update this since it's deprecated. OpenAI is shutting it down soon too: May 7, 2026.
|
|
||
| settings: Mapping[str, Any] = field(default_factory=dict) | ||
| delta: Optional["ServiceSettings"] = None | ||
| service: Optional["FrameProcessor"] = None |
There was a problem hiding this comment.
This follows the pattern of how we do service-specific targeting in ServiceSwitcherRequestMetadataFrame and ManuallySwitchServiceFrame.
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
markbackman
left a comment
markbackman
left a comment
There was a problem hiding this comment.
Makes sense! I agree with not supporting OpenAI Realtime Beta.
…in the deprecated `OpenAIRealtimeBetaLLMService`
kompfner
deleted the
pk/service-settings-update-frame-can-target-specific-service
branch
2 participants
…eting a specific service instance
When
serviceis set and doesn't match, the service forwards the frame instead of consuming it. This allows targeting a specific service when multiple services of the same type exist in the pipeline.