Fix stale state in user turn stop strategies between turns#4057
Merged
markbackman merged 2 commits intomainfrom Mar 17, 2026
Merged
Fix stale state in user turn stop strategies between turns#4057markbackman merged 2 commits intomainfrom
markbackman merged 2 commits intomainfrom
Conversation
Reset stop strategies at turn start (not just turn stop) so that late transcriptions arriving between turns do not leave stale _text that causes premature stops on the next turn. Also cancel pending timeout tasks in reset() for both SpeechTimeout and TurnAnalyzer strategies.
This was referenced Mar 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
markbackman
added a commit
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The issue filed in #4053 highlights a case where state can bleed over between one turn to the next. This PR attempts to clean up the state between turns to ensure we don't have any state carrying over.
Summary
TranscriptionFramearrived after a turn ended but before the next one started, its text would persist as stale state into the next turn, triggering an immediate stop before the current turn's real transcript arrived.if self._user_turn: returnguard in_trigger_user_turn_startensures this only fires once per turn, not on mid-turn VAD restarts (speak-pause-speak).SpeechTimeoutUserTurnStopStrategyandTurnAnalyzerUserTurnStopStrategyare now cancelled duringreset()to prevent stale timeouts from firing after a turn boundary.Testing
Fixes