fix: resolve raw language strings through Language enum for proper service conversion#4058
Merged
markbackman merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
…rvice conversion Raw strings like "de-DE" passed as the language parameter to TTS/STT services were bypassing the Language enum resolution logic, causing silent failures (e.g. ElevenLabs expects "de" not "de-DE"). Now raw strings are first converted to Language enums so they go through the same resolve_language() path, with a warning logged for unrecognized strings.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
markbackman
added a commit
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"de-DE"silently failing when passed to TTS/STT services. Previously, raw strings bypassed theLanguageenum resolution logic and were sent directly to the provider API (e.g. ElevenLabs expects"de", not"de-DE"), causing no audio output with no error.Languageenums first so they go through the sameresolve_language()path as enum values, properly resolving regional codes to service-expected formats.TTSServiceandSTTServicebase classes, covering both init-time and runtime update paths.Testing
23 tests covering all permutations of:
Languageenum (base),Languageenum (regional), raw string (base), raw string (regional), unrecognized string,None_update_settings()🤖 Generated with Claude Code