fix: always include parameters in Genesys AudioHook messages#4093
Merged
markbackman merged 2 commits intopipecat-ai:mainfrom Mar 20, 2026
Merged
fix: always include parameters in Genesys AudioHook messages#4093markbackman merged 2 commits intopipecat-ai:mainfrom
markbackman merged 2 commits intopipecat-ai:mainfrom
Conversation
The AudioHook protocol requires every message to carry a `parameters` object. `_create_message` conditionally included it only when parameters were truthy, so pong responses and closed responses without outputVariables were sent without the field. Clients that validate message structure (including the Genesys reference implementation) rejected these messages, which broke server sequence tracking and prevented outputVariables from reaching the Architect flow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
markbackman
approved these changes
Mar 20, 2026
Contributor
markbackman
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution 🙇
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
markbackman
pushed a commit
that referenced
this pull request
Mar 21, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AudioHook protocol requires every message to include a
parametersobject (even if empty{}). The_create_messagemethod conditionally included it only when parameters were truthy:This meant
pongresponses andclosedresponses withoutoutputVariableswere sent without aparametersfield at all.The Genesys reference client validates every incoming message with
isMessageBase, which requiresisJsonObject(msg['parameters']). Without the field, the message fails validation and triggers a fatal protocol error. This causes a cascade:pong→ doesn't update itsserverseqtrackerclosed) arrives with a higher-than-expectedseq→ protocol errorclosed→outputVariablesnever reach the Architect flowFix
Testing
client/). Before the fix, the client loggedProtocol error: Current serverseq=1 and incoming message has seq=3and the session ended inCLOSING-ERROR. After the fix, the session completes cleanly:Changelog
Included as
changelog/0000.fixed.md— happy to rename to the PR number once assigned.🤖 Generated with Claude Code