vmlifecycle - aws - add support for setting volume type #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabeyta
added a commit
to rabeyta/docs-platform-automation
that referenced
this pull request
Dec 3, 2024
add BootDiskType to example due to PR pivotal-cf/om#680 Co-authored-by: Shawn Neal <[email protected]>
rabeyta
added a commit
to rabeyta/docs-platform-automation
that referenced
this pull request
Dec 3, 2024
add boot_disk_type to example due to PR pivotal-cf/om#680 Co-authored-by: Shawn Neal <[email protected]>
default to gp2 (current behavior). allows user to define boot_disk_type in their aws config to instruct the type of volume to use when modifying the volume after vm creation refactoring aws lifecycle create to no longer perform a modify volume after initial creation. pass those disk options to initial creation to allow users to modify the volume if necessary after initial create without a penalty. aws imposes a 6 hour cool down between changes and this allows a user to modify vs the create causing a 6 hour cooldown before the next change is allowed Co-authored-by: Shawn Neal <[email protected]>
rabeyta
force-pushed
the
refactorAwsLifeycleCreate
branch
from
c2bf4ec to
d379930
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default to gp2 (current behavior). allows user to define boot_disk_type in their aws config to instruct the type of volume to use during vm creation
refactoring aws lifecycle create to no longer perform a modify volume after initial creation. pass those disk options to initial creation to allow users to modify the volume if necessary after initial create without a penalty. aws imposes a 6 hour cool down between changes and this allows a user to modify vs the create causing a 6 hour cooldown before the next change is allowed