fix: BitmapFontManager getFont emitting TextStyle update event#11835
Merged
Zyie merged 3 commits intopixijs:devfrom Jan 30, 2026
Merged
fix: BitmapFontManager getFont emitting TextStyle update event#11835Zyie merged 3 commits intopixijs:devfrom
Zyie merged 3 commits intopixijs:devfrom
Conversation
commit: |
99a71d7 to
c2e1475
Compare
Contributor
Author
|
Added unit tests to verify that BitmapFontManager.getFont no longer emits a TextStyle update event. |
Zyie
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes an issue where BitmapFontManager.getFont() could emit a TextStyle update event as a side effect.
Instead of assigning lineHeight via the setter on a prototype-based style clone, the value is now defined directly on the cloned style instance to avoid triggering unintended updates.
Pre-Merge Checklist
Tests and/or benchmarks are included (behavior verified via manual reproduction)
Documentation is changed or added (not required for this internal fix)
Lint process passed (npm run lint)
Tests passed (npm run test)
Fixes #11723