chore: increase HTMLText visual test wait from 250ms to 350ms#11891
Conversation
Fixes sporadic WebGPU failures caused by insufficient wait time for async HTMLText texture generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughIncreased post-render delays from 250ms to 350ms across 32+ HTML text visual test scene files in tests/visual/scenes/text-html/. Changes applied uniformly across all files. No logic, control flow, or error handling modifications. No public API or exported entity signature changes. All files show +1/-1 line changes. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
commit: |
|
|
||
| renderer.render(scene); | ||
| await new Promise((resolve) => setTimeout(resolve, 250)); | ||
| await new Promise((resolve) => setTimeout(resolve, 350)); |
There was a problem hiding this comment.
As a follow up would be good to replace this Promise with built in setTimeout from node's timer/promises? Would really help simplify these waits.
Overview
setTimeoutto wait for async texture generation (font loading, SVG-to-image, canvas conversion). The 250ms wait was insufficient for WebGPU, which has an extra canvas conversion step, causing sporadic failures.Fixes
Chores
tests/visual/scenes/text-html/*.scene.tsfiles:setTimeout(resolve, 250)->setTimeout(resolve, 350)Pre-Merge Checklist
Overview
Fixes