Fix vtctld deployment to allow ListBackups to work#356
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
commented
Jan 10, 2023
Comment on lines
+182
to
+188
| // We don't know which location to use for vtctld. | ||
| // If there are more than one locations configured, we can only choose one. | ||
| // Here we opt to take the first one. | ||
| if len(vt.Spec.Backup.Locations) != 0 { | ||
| spec.BackupLocation = &vt.Spec.Backup.Locations[0] | ||
| } | ||
| specs = append(specs, spec) |
Contributor
Author
There was a problem hiding this comment.
This here is worth noting. A user can setup multiple backup locations and use different ones in different tablet pools. However, we can only configure the vtctld with the flags to support one implementation. For now I have chosen to take the first one.
Contributor
There was a problem hiding this comment.
This should be fine. Even though operator's spec allows this, it is not supported by Vitess itself.
Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR passes the required flags, volumes, volume mounts and environment variables to get ListBackups to work with vtctld.
Related Issues