Skip to content

Upgrade default etcd version to 3.5.17#654

Merged
frouioui merged 2 commits into
planetscale:mainfrom
GrahamCampbell:patch-1
Jan 30, 2025
Merged

Upgrade default etcd version to 3.5.17#654
frouioui merged 2 commits into
planetscale:mainfrom
GrahamCampbell:patch-1

Conversation

@GrahamCampbell

@GrahamCampbell GrahamCampbell commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

This PR upgrades the default etcd version to 3.5.17.

Corresponding PR on vitess: vitessio/vitess#17653

@GuptaManan100

Copy link
Copy Markdown
Contributor

The DCO check seems to be failing 😕. Did you add the -s flag while committing?

@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

Made the commit from the GitHub webapp. 🤷

@frouioui frouioui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The etcd version should be changed everywhere both in vitess and vtop.

@frouioui

Copy link
Copy Markdown
Member

Have you tested upgrade paths with a vitess cluster on K8S using the previous etcd version, upgrading to the other etcd version? Same thing with downgrades.

@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

Not tested. PR based on #447.

@frouioui

Copy link
Copy Markdown
Member

In this case we need to do #447 (comment) too :)

@frouioui frouioui added the WIP [Do not merge] Not ready for review or merging. label Jan 17, 2025
@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

Re-pushed with a signed off commit.

@frouioui frouioui removed the WIP [Do not merge] Not ready for review or merging. label Jan 21, 2025
frouioui
frouioui previously approved these changes Jan 21, 2025

@frouioui frouioui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you modify the release notes summary for the next release (2.15.0) to include a note on how to proceed with this newer etcd version, #447 (comment).

@frouioui frouioui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a PR on vitess to make the etcd version match too please, we use v3.3.10 in the tests. We also use the ETCD_VER env variable in several places, in the vitess repo, which should be set to the same version as here.

Signed-off-by: Graham Campbell <hello@gjcampbell.co.uk>
Signed-off-by: Graham Campbell <hello@gjcampbell.co.uk>
@frouioui frouioui merged commit 63f2ac7 into planetscale:main Jan 30, 2025
@GrahamCampbell GrahamCampbell deleted the patch-1 branch January 30, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants