pass on the sidecarDbName when creating a keyspace#662
Merged
Conversation
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
mcrauwel
force-pushed
the
mcrauwel/allow-setting-sidecarDbName
branch
from
5109b64 to
f31cb56
Compare
Signed-off-by: Matthias Crauwels <matthias.crauwels@planetscale.com>
frouioui
reviewed
Feb 11, 2025
Member
frouioui
left a comment
frouioui
left a comment
There was a problem hiding this comment.
LGTM. Only thing missing is to re-generate the operator-latest.yaml file which we use to run our E2E tests and examples. To do this, you can run the following command:
make generate && kustomize build ./deploy > build/_output/operator.yaml
The output (build/_output/operator.yaml) will have to be copied to test/endtoend/operator/operator-latest.yaml. Once copied, you will want to revert unwanted changes on lines: 7698 and 7702.
Finally, the new changes brought to operator-latest.yaml will need to be ported over to the vitess OSS repository to the file: examples/operator/operator.yaml.
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
mcrauwel/allow-setting-sidecarDbName
branch
from
38edde6 to
c1099a2
Compare
frouioui
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #660