Skip to content

Update config.json#669

Merged
frouioui merged 4 commits into
planetscale:mainfrom
Danmark:patch-1
Mar 20, 2025
Merged

Update config.json#669
frouioui merged 4 commits into
planetscale:mainfrom
Danmark:patch-1

Conversation

@Danmark
Copy link
Copy Markdown
Contributor

@Danmark Danmark commented Mar 3, 2025

Fix broken links

@frouioui
Copy link
Copy Markdown
Member

frouioui commented Mar 3, 2025

Hi @Danmark, the DCO check is failing. Do you mind fixing it?

https://github.com/planetscale/vitess-operator/pull/669/checks?check_run_id=38087049321

To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.

In your local branch, run: git rebase HEAD~1 --signoff

Force push your changes to overwrite the branch: git push --force-with-lease origin patch-1

Comment thread docs/api/config.json Outdated
@Danmark
Copy link
Copy Markdown
Contributor Author

Danmark commented Mar 3, 2025

Hi @Danmark, the DCO check is failing. Do you mind fixing it?

Yeah, I'll fix that.
I created the commit from the github web gui and I don't think it's supported there.

@Danmark
Copy link
Copy Markdown
Contributor Author

Danmark commented Mar 3, 2025

I have updated the PR according to your comments

@frouioui
Copy link
Copy Markdown
Member

frouioui commented Mar 3, 2025

https://github.com/planetscale/vitess-operator/actions/runs/13639862753/job/38127627553?pr=669 is failing, you will have to re-generate the api documentation (make generate)

Signed-off-by: Viktor Fogelberg <viktor.fogelberg@gmail.com>
@Danmark
Copy link
Copy Markdown
Contributor Author

Danmark commented Mar 5, 2025

new docs generated

@Danmark
Copy link
Copy Markdown
Contributor Author

Danmark commented Mar 13, 2025

@frouioui anything more missing?

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Copy Markdown
Member

@Danmark, sorry for the delay. There was a few conflicts and other PRs going on. This should now be ready, I'll get this reviewed and merged.

@frouioui frouioui merged commit ded6490 into planetscale:main Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants