bump the vitess version to main#722
Merged
Merged
Conversation
mdlayher
approved these changes
Sep 24, 2025
| // Invariant: number of parts must be between 1-65536. This is enforced via | ||
| // the CRD. | ||
| ranges, err := key.GenerateShardRanges(int(p.Parts)) | ||
| ranges, err := key.GenerateShardRanges(int(p.Parts), 0) |
Member
There was a problem hiding this comment.
I don't understand the meaning of 0 here, mind leaving a comment?
Member
Author
There was a problem hiding this comment.
0 is the default value in Vitess and is a no-op, I am working on a follow up PR to actually expose this via the CRD and set this value
nickvanw
approved these changes
Sep 24, 2025
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
bump-vitess-version
branch
from
de96098 to
60894ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #721.
This PR bumps the vitess go dependency to the latest commit on the
mainbranch.With vitessio/vitess#18642, some changes were done to the controller manager to properly bind with the new flag format.