Allow deep linking to password protected shared links #5954
+154
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
commented
Dec 16, 2025
Comment on lines
9
to
10
| # should be {"hello world", "hello%20world"}, is | ||
| {"hello world", "hello+world"}, |
Contributor
Author
There was a problem hiding this comment.
@RobertJoonas I wanted to bring this to your attention: according to this test, DashboardQuerySerializer isn't yet quite the same as the JS one. It's serializing space as + not the URI encoded %20. Dashboard ATM parses + value as +.
apata
force-pushed
the
add-return-to-for-shared-links-login
branch
from
13beb42 to
7d17207
Compare
apata
force-pushed
the
add-return-to-for-shared-links-login
branch
from
7d17207 to
a0311a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds return to param for deep linking to password protected shared links
Tests
Changelog
Documentation
Dark mode