-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve reports layout #5962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanne-san
wants to merge
21
commits into
master
Choose a base branch
from
sanne-report-layout-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+932
−546
Open
Improve reports layout #5962
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
beb869f
Improve reports layout
sanne-san 848fafd
Update map colors
sanne-san 01b2258
Remove unused `sectionTitle` function and ensure Goals tab label upda…
sanne-san 949dd50
Fix formatting issues
sanne-san b1a9cf8
Fix another formatting issue
sanne-san 1fab2d7
Refactor referrer list to use new ReportLayout structure
sanne-san 0a86781
Show 'Conversions' instead of 'Current visitors' when both conversion…
sanne-san 65e1d96
Improve imported query unsupported warning icon and tooltip
sanne-san 7f31c9e
Make active tab bold to improve contrast
sanne-san b804a76
Various small fixes
sanne-san 0b79b17
Merge branch 'master' into sanne-report-layout-improvements
sanne-san f3d6c56
Remove group/report class from report layout
sanne-san b430b6c
Improve tab button styles
sanne-san 973e73d
Change font weight for report header
sanne-san add6ac6
Apply feedback on MoreLink state handling
sanne-san 10e90d8
Switch to MoreLinkState enum for better state management
sanne-san 2a8bbdc
Linting
sanne-san c26feb3
Fix formatting
sanne-san 2f09395
Vertically center-align CTA notice
sanne-san 1c011fd
Update assets/js/dashboard/nav-menu/segments/searchable-segments-sect…
sanne-san 92b76fd
Fix tooltip z-index issue
sanne-san File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import React, { ReactNode } from 'react' | ||
| import classNames from 'classnames' | ||
|
|
||
| export type PillProps = { | ||
| className?: string | ||
| children: ReactNode | ||
| } | ||
|
|
||
| export function Pill({ className, children }: PillProps) { | ||
| return ( | ||
| <div | ||
| className={classNames( | ||
| 'flex items-center shrink-0 h-fit rounded-md bg-green-50 dark:bg-green-900/60 text-green-700 dark:text-green-300 text-xs font-medium px-2.5 py-1', | ||
| className | ||
| )} | ||
| > | ||
| {children} | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Why are we focusing the search in 100ms and not instantly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delay is to account for the animation of the popover.