Two fixes related to main graph and revenue metrics#6331
Open
RobertJoonas wants to merge 4 commits intomasterfrom
Open
Two fixes related to main graph and revenue metrics#6331RobertJoonas wants to merge 4 commits intomasterfrom
RobertJoonas wants to merge 4 commits intomasterfrom
Conversation
This fixes a 500 error where we're trying to optimistically fetch the main graph with a stored revenue metric, while the goal filter has been removed. Rather than dropping revenue metrics in QueryOptimizer (which does not validate anything), we will do it in QueryBuilder instead. Query building will fail when dropping revenue metrics leaves query.metrics empty.
RobertJoonas
force-pushed
the
fix-graph-revenue-metric-500
branch
from
e9a5f22 to
2df67ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
QueryBuilder.do_builda bit better, using a pipeline with steps rather than a long function.Tests
Changelog
Documentation
Dark mode