This repository was archived by the owner on Sep 11, 2025. It is now read-only.
WIP upgrade to Jest 28 #797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klarstrup
reviewed
May 11, 2022
| } | ||
| const browserType = getBrowserType(browserName) | ||
| const device = this._config.device | ||
| const device = this._config.device.projectConfig |
Collaborator
|
Merged inside #801 |
Collaborator
|
Should be done in v2.0.0: https://github.com/playwright-community/jest-playwright/releases/tag/v2.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started upgrading this lib to support Jest 28, and worked through a couple of errors that I got when running it with Jest 28.
But quite a few type errors appeared and now it seems to just hang up and OOM instead of printing errors.
I haven't had time now to further dive into it.
@maintainers feel free to use this as a base and push any further changes to it to make it compatible with Jest 28.
Fixes #796