Skip to content

[Suggestion] Move the ImageExport's Async API to Task #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WhiteBlackGoose opened this issue Jul 8, 2022 · 0 comments · Fixed by #321
Closed

[Suggestion] Move the ImageExport's Async API to Task #320

WhiteBlackGoose opened this issue Jul 8, 2022 · 0 comments · Fixed by #321

Comments

@WhiteBlackGoose
Copy link
Contributor

WhiteBlackGoose commented Jul 8, 2022 •
edited
Loading

It currently returns FSharpAsync<T>, which is fine within F#, but creates awkward interop with C#:

await FSharpAsync.StartAsTask(ImageExport.exportAsJPG(...))
@WhiteBlackGoose WhiteBlackGoose changed the title [Suggestion] Move the ImageExport [Suggestion] Move the ImageExport's Async API to Task Jul 8, 2022
WhiteBlackGoose added a commit to WhiteBlackGoose/Plotly.NET that referenced this issue Jul 9, 2022
@WhiteBlackGoose
plotly#320, plotly#306
b35cb37
@WhiteBlackGoose WhiteBlackGoose mentioned this issue Jul 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewriting Async API in ImageExport WhiteBlackGoose/Plotly.NET
1 participant
@WhiteBlackGoose