Naming fixes #114
Merged
Naming fixes #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kMutagene
approved these changes
Aug 13, 2021
| @@ -47,6 +47,7 @@ The central type that gets created by all Chart constructors is `GenericChart`, | |||
| *) | |||
|
|
|||
| (***do-not-eval***) | |||
| [<NoComparison>] | |||
There was a problem hiding this comment.
It yielded a warning that there are types which do not override Equals. So it suggested me adding this attribute.
There was a problem hiding this comment.
I think here we can safely ignore that, because this is just a showcase of how the type looks like internally. But ill rework this page anyways so it can stay as it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105