Skip to content

Added ShowWithDescription and ShowFileWithDescription #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

kkkmail
Copy link
Contributor

@kkkmail kkkmail commented Jan 23, 2019

  1. Added two functions: ShowWithDescription and ShowFileWithDescription.
  2. Minor white space fixes.
  3. .paket/Paket.Restore.targets was updated by Visual Studio.

@kkkmail kkkmail requested a review from muehlhaus January 23, 2019 15:42
@kMutagene kMutagene self-requested a review March 13, 2019 10:19
Copy link
Collaborator

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @kkkmail, thank you for your contribution and sorry for the late reply. I have a request for you: could you rebase your PR to the developer branch? i have a few changes coming too and i will test them together with your changes on that branch before merging into master and updating the nuget package

@kkkmail
Copy link
Contributor Author

kkkmail commented Mar 13, 2019

@kMutagene Sure. Give me a day or so, please.

@kkkmail kkkmail changed the base branch from master to developer March 13, 2019 21:41
@kkkmail
Copy link
Contributor Author

kkkmail commented Mar 13, 2019

@kMutagene

  1. Done. I resolved merge conflicts and switched the base to developer as it seems more appropriate.
  2. Please, double check lib\Formatting folder as it looks that it is missing proper .gitignore - it pushes DLLs and other stuff, which is not really supposed to be pushed to the repo.
  3. Please, feel free to merge the branch when it seems fit.

Thanks.

@kMutagene
Copy link
Collaborator

Thank you.

Please, double check lib\Formatting folder as it looks that it is missing proper .gitignore - it pushes DLLs and other stuff, which is not really supposed to be pushed to the repo.

Im afraid this is working as intended. The files there are a temporary fix for the unfinished transition to .netcore of FSharp.Formatting, the tool we use to build the docs. It is currently not possible to display plotly charts on the generated pages without this custom version i placed in the .lib folder. I hope i can remove them soon.

@kMutagene kMutagene merged commit 1d2891d into developer Mar 14, 2019
@kMutagene kMutagene deleted the kk-master branch October 21, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants