-
Notifications
You must be signed in to change notification settings - Fork 99
Running image export bug fixed #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why 😢 . It produces the same image, but different string, varying in character 1002. The CI is on ubuntu 22.04, just like my machine... |
Yeah that's the exact reason why i gave up on those tests and just started to skip them, the exact string does not seem to be deterministic (although it's kinda strange) |
Regarding the
|
// https://github.com/hardkoded/puppeteer-sharp/issues/1211 | ||
launchOptions.Args <- [| "--no-sandbox" |] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be linux-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not think we need to hard-code this at all. I have used this lib on linux without setting this. as we expose the launch settings, this can be set by the user if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's imo too obscure. I spent some time investigating it, and we leave it as it, not working for some linux users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this on the contrary guaranteed to work everywhere else where it wasn't needed before? if so, i guess theres no harm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say for sure. Windows and Linux tests pass though. Is there some reason why we don't have those for MacOS btw?
(also I can set this option only for Linux platform, this is no problem)
The issue is that when rendering an image it fails to start chromium browser on Linux