Skip to content

Do not create structure with NULL to remove warnings #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 2 commits into from
Oct 21, 2019
Merged

Do not create structure with NULL to remove warnings #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d41a675
Do not create structure with NULL to remove warnings
Oct 15, 2019
599b851
Add test to prove #1299 fix
Oct 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions R/plotly_build.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,12 @@ plotly_build.plotly <- function(p, registerFrames = TRUE) {
)
for (i in x$.plotlyVariableMapping) {
# try to reduce the amount of data we have to send for non-positional scales
x[[i]] <- structure(
if (i %in% npscales()) uniq(d[[i]]) else d[[i]],
class = oldClass(x[[i]])
)
entry <- if (i %in% npscales()) uniq(d[[i]]) else d[[i]]
if (is.null(entry)) {
x[[i]] <- NULL
} else {
x[[i]] <- structure(entry, class = oldClass(x[[i]]))
}
}
x
})
Expand Down
7 changes: 7 additions & 0 deletions tests/testthat/test-ggplot-lines.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,10 @@ test_that("geom_linerange() without a y aesthetic translates to a path", {
)

})

test_that("NA values do not cause a lot of warnings when ploting (#1299)", {
df <- data.frame(x=1:2, y=NA)
p <- plot_ly(df, x=~x, y=~y)
expect_warning(plotly_build(p), "Ignoring")
expect_failure(expect_warning(plotly_build(p), "structure"))
})