-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Investigate relayout & react + axis constraints behavior #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Found a bug in https://codepen.io/etpinard/pen/qYopzp introduced in |
PR #2628 fixed the 🪲 reported above in #2540 (comment), but many issues remain. Pasting #2628 (comment) here: A few more comments on constrained axes, that should be followed up in #2540:
plotly.js/src/plot_api/plot_api.js Line 2039 in a132b85
with
and @alexcjohnson 's #2628 (comment)
Do we have a test of setting mutually-exclusive range values, as per the comment on that line? If we do, and the result correctly fixes them for the constraints, then go for it! |
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
In PR #2527, a few oddities with relayout on graphs with axis constraints (i.e.
(x|y)axis.constrain: 'range' || 'domain'
) were detected.From #2527 (comment) and below, tests coverage was deemed inadequate to assume anything about the current behavior. The first step would be to beef up the coverage there. Next, determine whether or not graphs with axis constraints do need to go though the editType
calc
on axis range relayouts. Finally, we should lock down the limitations (if any) of editTypeaxrange
for graphs with axis constraints.cc @alexcjohnson
The text was updated successfully, but these errors were encountered: