Skip to content

Investigate relayout & react + axis constraints behavior #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etpinard opened this issue Apr 11, 2018 · 3 comments
Closed

Investigate relayout & react + axis constraints behavior #2540

etpinard opened this issue Apr 11, 2018 · 3 comments
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

In PR #2527, a few oddities with relayout on graphs with axis constraints (i.e. (x|y)axis.constrain: 'range' || 'domain') were detected.

From #2527 (comment) and below, tests coverage was deemed inadequate to assume anything about the current behavior. The first step would be to beef up the coverage there. Next, determine whether or not graphs with axis constraints do need to go though the editType calc on axis range relayouts. Finally, we should lock down the limitations (if any) of editType axrange for graphs with axis constraints.

cc @alexcjohnson

@etpinard
Copy link
Contributor Author

Found a bug in https://codepen.io/etpinard/pen/qYopzp

peek 2018-05-10 12-26

introduced in 1.36.0 (probably from PR #2527) where the y-axis is getting re-position properly. This should be a good starting point for this ticket here.

@etpinard etpinard changed the title Investigate relayout + axis constraints behavior Investigate relayout & react + axis constraints behavior May 14, 2018
@etpinard
Copy link
Contributor Author

PR #2628 fixed the 🪲 reported above in #2540 (comment), but many issues remain.

Pasting #2628 (comment) here:

A few more comments on constrained axes, that should be followed up in #2540:

  • Could making range relayout go through editType "plot" (instead of "calc") be sufficient? When replacing this line

flags.calc = true;

with flags.plot = true, no tests are failing.

  • I think Plotly.react is broken with constrained axes. I'm not sure if it's always been broken or if the recently-added "axrange" edit did it 😕

and @alexcjohnson 's #2628 (comment)

Could making range relayout go through editType "plot" (instead of "calc") be sufficient?

Do we have a test of setting mutually-exclusive range values, as per the comment on that line? If we do, and the result correctly fixes them for the constraints, then go for it!

@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants