Plots.supplyDeffaults subplot type cache doesn't allow dynamic trace module imports

[dan8f]

Hi team,

collectableSubplotTypes gets cached and this leads to inaccurate subplot lists if new traces are registered dynamically:

plotly.js/src/plots/plots.js

Lines 582 to 614 in 51b5c25

	var collectableSubplotTypes;
	function emptySubplotLists() {
	var out = {};
	var i, j;
	if(!collectableSubplotTypes) {
	collectableSubplotTypes = [];
	var subplotsRegistry = Registry.subplotsRegistry;
	for(var subplotType in subplotsRegistry) {
	var subplotModule = subplotsRegistry[subplotType];
	var subplotAttr = subplotModule.attr;
	if(subplotAttr) {
	collectableSubplotTypes.push(subplotType);
	// special case, currently just for cartesian:
	// we need to enumerate axes, not just subplots
	if(Array.isArray(subplotAttr)) {
	for(j = 0; j < subplotAttr.length; j++) {
	Lib.pushUnique(collectableSubplotTypes, subplotAttr[j]);
	}
	}
	}
	}
	}
	for(i = 0; i < collectableSubplotTypes.length; i++) {
	out[collectableSubplotTypes[i]] = [];
	}
	return out;
	}

For example if we load Plotly, plot a graph and later dynamically register mapbox and plot a mapbox it will error since coorect subplotTypes are not passed to handleSubplotDefaults.

Could we simply not cache subplotTypes or reset when we register new traces?

Regards

[etpinard]

Thanks for the report!

if new traces are registered dynamically

Could you share a code snippet to help us understand what you're trying to achieve? Thank you very much.

[dan8f]

Hi @etpinard

Imagine we have component Timeseries.js as:

import Plotly from 'plotly.js/lib/core'; export default function() { Plotly.plot(...); }

And component Mapbox.js as:

import Plotly from 'plotly.js/lib/core'; import Mapbox from 'plotly.js/lib/scattermapbox'; Plotly.register(Mapbox); export default function() { Plotly.plot(...); }

And then in our main index.js we dynamically import Timeseries and plot a graph and later on import Mapbox and plot a map.

import("Timeseries").default(); and later...>> import("Mapbox").default();

This will produce an error in handleSubplotDefaults. The subplot types for Mapbox component should include 'Mapbox' but since we have cached subplot types when first rendering the timeseries, then chart we will miss them.

Let me know if this doesn't help to visualize it.

Regards

[etpinard]

That makes perfect sense. Thanks. We'll fix that!