Skip to content

Throttle selectPoints #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcjohnson merged 10 commits into from
Sep 28, 2017
Merged

Throttle selectPoints #2040

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a6df912
generalized event throttling routine
alexcjohnson Sep 26, 2017
aa434dd
move getGraphDiv to lib so we can use it outside plot_api
alexcjohnson Sep 26, 2017
753b2c9
unwrap [].push.apply
alexcjohnson Sep 27, 2017
256c5c7
throttle just the selectPoints part of box/lasso selection
alexcjohnson Sep 27, 2017
80508e8
throttle.done method and test updates
alexcjohnson Sep 28, 2017
0861736
fix docs for getGraphDiv
alexcjohnson Sep 28, 2017
1968af7
Merge branch 'master' into throttle-select
alexcjohnson Sep 28, 2017
6da3cfa
remove silently broken and obsolete select box node creation tests
alexcjohnson Sep 28, 2017
b6d64be
alter argument order of throttle.throttle
alexcjohnson Sep 28, 2017
811073e
clean up geo_test for new throttle
alexcjohnson Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/plots/cartesian/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,15 @@ module.exports = function prepSelect(e, startX, startY, dragOptions, mode) {
selection = [];
for(i = 0; i < searchTraces.length; i++) {
searchInfo = searchTraces[i];
[].push.apply(selection, fillSelectionItem(
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Sep 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a reported bug AFAIK, but this use of push.apply overloads the stack for large plots. Doesn't look to me as though any of the other places we use push.apply are susceptible to this issue.

Copy link
Contributor

@etpinard etpinard Sep 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone interested in writing a syntax test to 🔒 this down?

Copy link
Collaborator Author

@alexcjohnson alexcjohnson Sep 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do use push.apply in a few other places - but they get max a few items in the array so it's not a problem - so if we wanted to 🔒 it, we'd have to also remove those other uses.

Copy link
Contributor

@dy dy Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson funny enough I stumbled upon this stack overflow in selection for regl. I replaced it with .concat here https://github.com/plotly/plotly.js/pull/1869/files#diff-8c5d8f688f2bb41a18d35397e5f58864R211, since it is being called only as many times as there is traces per subplot, which is small. (related tweet)

var thisSelection = fillSelectionItem(
searchInfo.selectPoints(searchInfo, poly), searchInfo
));
);
if(selection.length) {
for(var j = 0; j < thisSelection.length; j++) {
selection.push(thisSelection[j]);
}
}
else selection = thisSelection;
}

eventData = {points: selection};
Expand Down