Multicategory inside ticks fixes #3326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... replacing (buggy) ax._boundingBox. This fixes ax title placement
on multicategory axes with mirror ticks
... where dividers and ticks go in opposite directions
|
A new era of reviews is starting now. Asking @archmoj and @antoinerg to review this thing! |
|
Nicely done 💃 |
|
Nice job reviewing! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #3300. Two multicategory fixes discovered when trying to clean up our
ax._boundingBoxmess.Edit: This PR fixes one more bug: https://codepen.io/nicolaskruchten/pen/roOzQO?editors=0010
cc @plotly/plotly_js