Skip to content

Fix axis autorange on doubleClick #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

etpinard
Copy link
Contributor

... on graphs w/ fixedrange:true axes and w/o set _rangeInitial

fixes #3347 cc @plotly/plotly_js

... on graphs w/ fixedrange axes and w/o set rangeInitial
@etpinard etpinard added bug something broken status: reviewable labels Dec 19, 2018
@archmoj archmoj assigned archmoj and unassigned archmoj Dec 19, 2018
@archmoj archmoj self-requested a review December 19, 2018 18:40
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @etpinard.
Please find my comments below:

@archmoj
Copy link
Contributor

archmoj commented Dec 19, 2018

A 💃 from my side.
Thank you @etpinard for the fix.

@etpinard etpinard merged commit 2e1bb3c into master Dec 19, 2018
@etpinard etpinard deleted the fix-double-click-autorange-wo-initial-range branch December 19, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixedrange=True is not applied correctly when updating figure through Plotly.react
2 participants