Bump dev deps 2019-02-10 #3532
Bump dev deps 2019-02-10 #3532
Conversation
| @@ -4047,7 +4110,8 @@ | |||
| "ansi-regex": { | |||
| "version": "2.1.1", | |||
| "bundled": true, | |||
| "dev": true | |||
| "dev": true, | |||
| "optional": true | |||
There was a problem hiding this comment.
I've got a difference when I npm i.
It seems we could remove this line ("optional": true) as well as few others below.
@etpinard please let me know if you wanted me to push a commit to remove those?
There was a problem hiding this comment.
Which version of npm are you using? I'm on 6.7.0
There was a problem hiding this comment.
My npm version is at 6.4.1
There was a problem hiding this comment.
Can you bump your npm version to 6.7.0 and try npm i again?
There was a problem hiding this comment.
Cool! With 6.7.0 I've got no difference.
|
Just as another note, this is the only difference I noticed between the current master and the new publish, which should be OK. |
Those are just randomly-generated string ids. This PR only upgrades dev dependencies, so yeah we're good. |
|
@etpinard Thanks for the PR. |
fixing this low-severity security alert
https://github.com/plotly/plotly.js/network/alert/package-lock.json/lodash/open
going from
to
and bumping a few other dev deps along the way.
cc @plotly/plotly_js