Add initial zh-CN translation based on ja.js dictionary strings#4276
Merged
etpinard merged 7 commits intoplotly:masterfrom Oct 28, 2019
boltomli:master
Merged
Add initial zh-CN translation based on ja.js dictionary strings#4276etpinard merged 7 commits intoplotly:masterfrom boltomli:master
etpinard merged 7 commits intoplotly:masterfrom
boltomli:master
Conversation
Contributor
|
Thanks very much for the PR, can you now please @ mention a few other speakers of this language who can help review your translations? |
Contributor
|
Ping @boltomli - do you know any other Github users that are native speakers of |
Collaborator
|
Maybe @byronz could take a look? |
Contributor
Author
|
@Sunshow might have time to check as well? |
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
byronz
reviewed
Oct 24, 2019
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
etpinard
reviewed
Oct 25, 2019
Contributor
|
Ok - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your interest in plotly.js!
Translations:
lib/locales/, not those indist/Features, Bug fixes, and others:
Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.
Before opening a pull request, developer should:
git rebasetheir local branch off the latestmaster,git addthedist/folder (thedist/is updated only on version bumps),package-lock.jsonfile (if any),Note that it is forbidden to force push (i.e.
git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, pleasegit merge masterinto your PR branch instead ofgit rebase master.