Skip non-numeric values in image trace plot #4325
Merged
Conversation
alexcjohnson
reviewed
Nov 1, 2019
archmoj
changed the title
alexcjohnson
approved these changes
Nov 1, 2019
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
Beautiful, love the new mock! 💃
Contributor
|
Nice PR @archmoj - can I why you made some of the colorscale attributes |
Contributor
Author
|
@etpinard Yes. That was for speed and ( if I recall ) not for calling |
Contributor
Yeah, that's very nice. Most colorscale computations for other traces are done during the calc step, so this is fantastic 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix in respect to @emmanuelle 's comment
#4301 (comment)
i.e. by drawing those pixels with full transparency.
before vs after demo
@alexcjohnson
cc: @nicolaskruchten
cc: @plotly/plotly_js