Skip to content

Apply reversed colorscale setting and coloraxis in contour and histogramcontour legends#4356

Merged
archmoj merged 4 commits intomasterfrom
fix4354-contour-legends-with-colorscale
Nov 18, 2019
Merged

Apply reversed colorscale setting and coloraxis in contour and histogramcontour legends#4356
archmoj merged 4 commits intomasterfrom
fix4354-contour-legends-with-colorscale

Conversation

@archmoj
Copy link
Copy Markdown
Contributor

@archmoj archmoj commented Nov 16, 2019

Fixes #4354 and fixes #4355

  • displays identical legends for identical graphs
  • use coloraxis colorscale (if defined) to style legend
  • use baseAttrs instead of plotAttrs in all trace/attributes.js files (refactor commit 0c00efc)

@alexcjohnson
@plotly/plotly_js
cc: @nicolaskruchten

@archmoj archmoj added bug something broken status: reviewable labels Nov 16, 2019
@archmoj archmoj changed the title Apply reversed colorscale setting in contour and histogramcontour legends Apply reversed colorscale setting and coloraxis in contour and histogramcontour legends Nov 16, 2019
@etpinard
Copy link
Copy Markdown
Contributor

💃 nicely done @archmoj (once that flaky test passes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem drawing legends of contour and histogram2dcontour when using coloraxis Apply reversescale in contour and histogram2dcontour legends

2 participants