Skip to content

Fix colorbar templating for "non-root" colorscales #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 4 commits into from
Jan 7, 2020
Merged

Fix colorbar templating for "non-root" colorscales #4470

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6942b10
fix colorbar templating for "non-root" colorscales
etpinard Jan 7, 2020
6be7023
add parcats + template mock
etpinard Jan 7, 2020
6615605
add treemap_coffee to list of flaky image tests
etpinard Jan 7, 2020
d4e619f
update treemap_coffee baseline
archmoj Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/image/compare_pixels_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ if(allMock || argv.filter) {
}

var FLAKY_LIST = [
'treemap_coffee',
Copy link
Copy Markdown
Contributor Author

@etpinard etpinard Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @archmoj something is off with this new mock. See https://circleci.com/gh/plotly/plotly.js/64411?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link - it failed 5 times in a row.

Copy link
Copy Markdown
Contributor

@archmoj archmoj Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pick 0175108 to fix that.

'treemap_textposition',
'treemap_with-without_values_template',
'trace_metatext',
Expand Down