-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Revise process of making bundles and simplify making partial bundles #5508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4bbe89a
rewrite code to generate partial bundles
archmoj c3a8b48
wrap Plotly to avoid unexpected character
archmoj 4f862ca
add extra_bundles - handle options in partial_bundle
archmoj e4c2f86
update README on how to use the script to make custom bundles
archmoj 836248c
remove note concerning non-ascii characters from README
archmoj 01136b7
write component files to lib
archmoj aeaf709
modify util/constants to write index files for our partial bundles in…
archmoj c937a6f
do not deprecate components in lib in v2
archmoj d29446e
commit changes to lib when bumping version
archmoj df67243
keep core reference in lib
archmoj 4772f90
reference lib in bundle tests where possible
archmoj e1c4cc3
update README
archmoj 8d902aa
use --name in partial bundle script
archmoj 0d00c52
add comment to the end of lib/index files
archmoj a66d56a
simple Plotly return from index
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,15 +3,25 @@ | |
var Plotly = require('./core'); | ||
|
||
Plotly.register([ | ||
// traces | ||
require('./bar'), | ||
require('./histogram'), | ||
require('./funnel'), | ||
require('./waterfall'), | ||
require('./pie'), | ||
require('./funnelarea'), | ||
require('./indicator'), | ||
require('./ohlc'), | ||
require('./candlestick'), | ||
require('./funnel'), | ||
require('./waterfall'), | ||
require('./indicator') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As you can see, |
||
|
||
// transforms | ||
require('./aggregate'), | ||
require('./filter'), | ||
require('./groupby'), | ||
require('./sort'), | ||
|
||
// components | ||
require('./calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = Plotly; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see,
image
andpie
used to be registered in a different order incartesian
bundles.