Skip to content

Path pattern fills #7280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 10 commits into from
Jun 9, 2025
Merged

Path pattern fills #7280

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa2e424
path pattern fills
alexcjohnson Nov 21, 2024
1e2aa92
why has vscode started adding weird imports I didn't ask for?
alexcjohnson Nov 22, 2024
c842f6b
changelog for arbitrary pattern fills
alexcjohnson Nov 22, 2024
8377544
schema update for path pattern fills
alexcjohnson Nov 22, 2024
50975ce
new pattern_bars baseline image
alexcjohnson Nov 22, 2024
e0395f6
put path pattern image test into a new mock and restore the old patte…
alexcjohnson Nov 22, 2024
24c4cb7
remove bad funnel attrs in mock and fix new baseline name
alexcjohnson Nov 22, 2024
dbcf4da
fix validation for arrayOk enums
alexcjohnson Nov 23, 2024
c2b1fad
remove obsolete keys from new pattern path mock
alexcjohnson Nov 23, 2024
5ba4543
Merge branch 'master' into alex/path-pattern-fill
alexcjohnson Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/plot_api/validate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,11 @@ function crawl(objIn, objOut, schema, list, base, path) {
} else if(!Lib.validate(valIn, nestedSchema)) {
list.push(format('value', base, p, valIn));
} else if(nestedSchema.valType === 'enumerated' &&
((nestedSchema.coerceNumber && valIn !== +valOut) || valIn !== valOut)
(
(nestedSchema.coerceNumber && valIn !== +valOut) ||
(!isArrayOrTypedArray(valIn) && valIn !== valOut) ||
(String(valIn) !== String(valOut))
Copy link
Collaborator Author

@alexcjohnson alexcjohnson Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're comparing the original data array to something we coerced off a deep copy, arrays that make it here will never be ===

)
) {
list.push(format('dynamic', base, p, valIn, valOut));
}
Expand Down