Fix repeated val case in scattermapbox convert step #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,7 +184,7 @@ function makeCircleGeoJSON(calcTrace, hash) { | |||
| // Translate vals in trace arrayOk containers | |||
| // into a val-to-index hash object | |||
| function translate(props, key, val, index) { | |||
| if(!hash[key][val]) hash[key][val] = index; | |||
| if(hash[key][val] === undefined) hash[key][val] = index; | |||
There was a problem hiding this comment.
Here hash[key][val] store indices in of arrayOk attribute. This check ⏫ was failing if a repeated value was found in the first marker.size or marker.color item as 0 is falsy.
|
Thanks for jumping on this so fast! 💃! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brief
The
mapbox-glAPI forarrayOkattributes (they call it data-driven 😃 ) links values in the features geojsonpropertiesfield to a set ofstops. These stops map the geojson properties values to mapbox-gl paint settings per feature (as opposed to a source-wide setting). Note that the stop values must be unique.