Skip to content

useless line in the _Quiver class definition #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
empet opened this issue Nov 25, 2021 · 0 comments
Open

useless line in the _Quiver class definition #3490

empet opened this issue Nov 25, 2021 · 0 comments
Labels
bug something broken P3 backlog

Comments

@empet
Copy link

empet commented Nov 25, 2021

In the _Quiver class definition (more precisely within the body of one of its methods) there is a useless line https://github.com/plotly/plotly.py/blob/master/packages/python/plotly/plotly/figure_factory/_quiver.py#L257 which just leads to repeating the calculations of the elements in the four lists under the for loop:

for index in range(len(self.end_x)):
    point1_x = [i - j * self.scaleratio for i, j in zip(self.end_x, seg1_x)]
    point1_y = [i - j for i, j in zip(self.end_y, seg1_y)]
    point2_x = [i - j * self.scaleratio for i, j in zip(self.end_x, seg2_x)]
    point2_y = [i - j for i, j in zip(self.end_y, seg2_y)]

The for line must be removed and the next four lines moved a tab at left.

lucafs added a commit to lucafs/plotly.py that referenced this issue Dec 2, 2021
@gvwilson gvwilson self-assigned this Jun 26, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added the P3 backlog label Aug 12, 2024
@gvwilson gvwilson changed the title There is a useless line in the _Quiver class definition useless line in the _Quiver class definition Aug 12, 2024
@gvwilson gvwilson added the bug something broken label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 backlog
Projects
None yet
Development

No branches or pull requests

2 participants