Explosion: implemented underwater explosion

[nicholass003]

Introduction

This PR implements underwater explosion for Underwater TNT

Minecraft.2024-09-21.10-12-07.mp4

Relevant issues

Changes

API changes

Behavioural changes

Backwards compatibility

Follow-up

Tests

I tested this PR by doing the following (tick all that apply):

• Writing PHPUnit tests (commit these in the tests/phpunit folder)
• Playtesting using a Minecraft client (provide screenshots or a video)
• Writing a test plugin (provide the code and sample output)
• Other (provide details)

[dktapps]

A better approach might be to allow the constructor to accept a list of BlockTypeTags (or type IDs) that it skips over, and then check those tags (or IDs) when looking at blocks to destroy. That would make it more flexible and enable custom use cases.

[nicholass003]

Is this the correct approach? I have several options for the variable that stores the list of BlockTypeIds namely :

• $excludedBlockTypeIds
• $ignoredBlockTypeIds

However, I think the name BlockTypeIds is too long, would you prefer $excludedBlockIds?

[nicholass003]

Should $excludedBlockTypeIds be public?

[dries-c]

Well if people wanted to change the blocks affected by the explosion they can always cancel the EntityPreExplodeEvent and make their own explosion

[github-actions]

This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days.

If there is no further activity, it will be closed in 28 days.

Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale.

[dktapps]

I stalled on merging this because I don't like the solution, but I don't currently have a better one. It's not been at the forefront of my mind lately. Will revisit it soon.