v9.0.0-rc.1 #978
Merged
v9.0.0-rc.1 #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native target had the least broken AnimatedLeaf type (from earlier commits).
This makes "AnimatedProp<string | string[] | undefined>" resolve to
string | string[] | FluidValue<string | string[]> | undefined
instead of
string | FluidValue<string | undefined> | (string | FluidValue<string>)[] | undefined
Complain via TS error when the "to" prop has a FluidValue type whose "T" param extends "void".
This variable decides if a SpringValue needs to be in the frameloop. Previously, it was using "value" (the current value) before the "reset" and "from" props were applied.
The "reverse" prop only affects a single update
It wasn't working for tests in "packages/core" :(
The implications of this commit are subtle. - The internal Animated node is now replaced (1) when the "set" method is passed a different value type and (2) when the "from" value type is changed before ever animating. - Before ever animating, the Animated node has its value updated to the newest "from" value. - Stop passing the "from" value to "computeGoal" when creating the Animated node. - Account for the "reverse" and "delay" props when deciding what the "from" value is.
It was a case of pre-optimization methinks
The only non-animated value type that's allowed in a SpringValue object is a string, and the "goal" local var will only be a string when it cannot be animated.
By default, it advances one frame, but that can be controlled.
- Ensure active animations cannot be interrupted by "to" prop changing to current value - Prevent pending animations when "to" prop changes to current value
This should fix #887, because changing of the "config.decay" prop now affects the "started" variable. Also, a new variable named "finished" detects if the current value equals the latest goal value.
The "props function" overload must come first, or else the other overloads will be used.
…on returned by useTransition
This only affects SpringValue objects owned by a Controller object.
FrameLoop is incompatible with r3f's render loop, because of how the FrameLoop calls r3f's `invalidate` function inside r3f's global effects queue. In doing that, the `invalidate` call is ignored, and the frameloop is effectively paused.
…s function is passed
otherwise its reference to `ctrls` will become outdated after a single rerender, because the `ctrls` array is only populated for render-based updates
ie: @react-spring/web should work in the same window as @react-spring/three
|
Whoa :) When is this coming to npm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://aleclarson.github.io/react-spring/v9