Skip to content

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Feb 5, 2025

Summary

Changes

  • Reordered the fix script execution sequence.
  • Now fix:lint runs first, followed by fix:format.

Reason

  • It’s generally better to run lint before format.
  • lint --fix catches and fixes code issues first.
  • prettier --write then formats the code for consistency.

This ensures a more natural and structured workflow.

Check List

  • pnpm run fix for formatting and linting code and docs

@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 5:57am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitzdemostarter

npm i https://pkg.pr.new/zustand@2997

commit: b409d3f

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't worry about it too much, but I agree it's slightly better.
I'm not sure how we could keep the script order in the future, but it's not critical anyways.

Fine, please send PRs to other repos.

@dai-shi dai-shi merged commit 08ec944 into pmndrs:main Feb 6, 2025
28 checks passed
@dai-shi
Copy link
Member

dai-shi commented Feb 6, 2025

Thanks.

@sukvvon sukvvon deleted the chore/reorder-fix-script branch February 6, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants