Skip to content

RFC: bindings_f08: Use normal MPI C binding to allow profiling by C code #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

N00byKing
Copy link

Pull Request Description

This PR changes some of the generated bindings for the mpi_f08 module to use the standard C MPI functions internally, allowing profiling tools to intercept them.
This matches the behavior of the Fortran 90 module, and the rest of the Fortran 2008 bindings, which already allowed for this (Fortran Interface -> Fortran _f08 Impl -> MPIR_ cdesc -> MPI C call).

I rely on this behavior to allow PnMPI and MUST [1] to run on Fortran 2008 code.
Without these changes, some interceptions work, while others do not.

I understand this may not be a supported workflow, but I find it useful nonetheless.
Pull Request is an RFC, feel free to reject if this change is unwanted.

[1] https://www.i12.rwth-aachen.de/cms/i12/forschung/forschungsschwerpunkte/lehrstuhl-fuer-hochleistungsrechnen/~nrbe/must/

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@hzhou
Copy link
Contributor

hzhou commented Jun 25, 2025

I think it is okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants