RFC: bindings_f08: Use normal MPI C binding to allow profiling by C code #7479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR changes some of the generated bindings for the mpi_f08 module to use the standard C MPI functions internally, allowing profiling tools to intercept them.
This matches the behavior of the Fortran 90 module, and the rest of the Fortran 2008 bindings, which already allowed for this (Fortran Interface -> Fortran _f08 Impl -> MPIR_ cdesc -> MPI C call).
I rely on this behavior to allow PnMPI and MUST [1] to run on Fortran 2008 code.
Without these changes, some interceptions work, while others do not.
I understand this may not be a supported workflow, but I find it useful nonetheless.
Pull Request is an RFC, feel free to reject if this change is unwanted.
[1] https://www.i12.rwth-aachen.de/cms/i12/forschung/forschungsschwerpunkte/lehrstuhl-fuer-hochleistungsrechnen/~nrbe/must/
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short description
Commit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.