Applying sharing capabilities to a site fails with 'Type' attribute is invalid

[plamber]

Category

• Bug

Describe the bug

When running this code passing the PnP.Core.Admin.Model.SharePoint SharingCapabilities

var tenantProperties = await pnpContext.GetSharePointAdmin().GetTenantPropertiesAsync();
tenantProperties.SharingCapability = capabilities;
await tenantProperties.UpdateAsync();

I am getting this type of exception.

The 'Type' attribute is invalid - The value 'List`1' is invalid according to its datatype 'http://schemas.microsoft.com/sharepoint/clientquery/2009:MethodParameterTypeType' - The Enumeration constraint failed.
ClientRequestId: bc8d93a0-b0ff-6000-32ba-0f79281160f8
ErrorTypeName: "System.Xml.Schema.XmlSchemaValidationException"

I noticed this error in 1.8.92. I haven't seen it in 1.8.0

[jansenbe]

@plamber : what value are you assigning to variable capabilitities ?

[plamber]

Hi @jansenbe,
I am passing the values from the enum PnP.Core.Admin.Model.SharePoint.SharingCapabilities.

Integers also have the same issue.

Maybe an important sidenote. We are provisioning a site before executing the test without additional delay.

Cheers,
Patrick

[jansenbe]

Does is also fail on an older site?

[plamber]

Tested with an 1h old site too

[plamber]

Hi,
I also tested it with an older site—same result.

Cheers

[plamber]

Hi @jansenbe,
I performed a couple of other tests. I can see that the version of PnP.Core.Admin 1.8.94 has the issue. Downgrading to 1.8.0 fixes the problem.

Is there a way for me to configure logging to view all calls with their payloads? By doing so I could provide more details on what is being passed by PnP Core.

Thank you,
Patrick

[jansenbe]

@plamber : I'll have a look at this today, most likely the generated CSOM XML payload is not valid. Doing a Fiddler trace helps or when the exception happens getting the CsomError error object (see https://pnp.github.io/pnpcore/using-the-sdk/basics-errorhandling.html#catching-a-pnp-core-sdk-exception-and-getting-the-exception-details) and outputting that

[jansenbe]

@plamber : this issue is a regression from the change that added extra tenant properties, seems one of them is not correctly serializing when being saved resulting in this error. This is 'bad' XML payload:

<Request AddExpandoFieldTypeSuffix="true" SchemaVersion="15.0.0.0" LibraryVersion="16.0.0.0"
    ApplicationName="pnp core sdk" xmlns="http://schemas.microsoft.com/sharepoint/clientquery/2009">
    <Actions>
        <SetProperty Id="4" ObjectPathId="1" Name="AllowedDomainListForSyncClient">
            <Parameter Type="Array"></Parameter>
        </SetProperty>
        <SetProperty Id="5" ObjectPathId="1" Name="BlockDownloadFileTypeIds">
            <Parameter Type="List`1">
                System.Collections.Generic.List`1[PnP.Core.Admin.Model.SharePoint.SPBlockDownloadFileTypeId]</Parameter>
        </SetProperty>
        <SetProperty Id="6" ObjectPathId="1" Name="ContentTypeSyncSiteTemplatesList">
            <Parameter Type="Array"></Parameter>
        </SetProperty>
        <SetProperty Id="7" ObjectPathId="1" Name="ExcludedBlockDownloadGroupIds">
            <Parameter Type="Array"></Parameter>
        </SetProperty>
        <SetProperty Id="8" ObjectPathId="1" Name="ExcludedFileExtensionsForSyncClient">
            <Parameter Type="Array"><Object Type="String"></Object></Parameter>
        </SetProperty>
        <SetProperty Id="9" ObjectPathId="1" Name="SharingCapability">
            <Parameter Type="Enum">3</Parameter>
        </SetProperty>
    </Actions>
    <ObjectPaths>
        <Method Id="3" ParentId="1" Name="Update" />
        <Identity Id="1"
            Name="a4d894a0-b0c8-6000-1002-9a042cbc1f07|908bed80-a04a-4433-b4a0-883d9847d110:6492ece7-7f5d-4499-8130-50e761e25bd9&#xA;Tenant" />
    </ObjectPaths>
</Request>

Will work on a fix.

[jansenbe]

@plamber : fixed. Will be part of the next nightly. Closing this one now, please create a new issue or re-open in case the problem persists.