Skip to content

The JSON value could not be converted to System.Int32 : Handle Pnp Provisioning template extraction failure from Project Management site template #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansenbe merged 1 commit into from
Dec 14, 2022
Merged

The JSON value could not be converted to System.Int32 : Handle Pnp Provisioning template extraction failure from Project Management site template #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sdk/PnP.Core/Model/SharePoint/Pages/Internal/CanvasPosition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal class CanvasPosition
/// Gets or sets JsonProperty "sectionIndex"
/// </summary>
[JsonPropertyName("sectionIndex")]
public int SectionIndex { get; set; }
public float SectionIndex { get; set; }

/// <summary>
/// Gets or sets JsonProperty "sectionFactor"
Expand Down
8 changes: 4 additions & 4 deletions src/sdk/PnP.Core/Model/SharePoint/Pages/Internal/Page.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ private void LoadFromHtml(string html, string pageHeaderHtml)
{
if (sectionData.Position.LayoutIndex.HasValue)
{
currentSection.AddColumn(new CanvasColumn(currentSection, sectionData.Position.SectionIndex, sectionData.Position.SectionFactor, sectionData.Position.LayoutIndex.Value));
currentSection.AddColumn(new CanvasColumn(currentSection, (int)sectionData.Position.SectionIndex, sectionData.Position.SectionFactor, sectionData.Position.LayoutIndex.Value));
currentColumn = currentSection.Columns.Where(p => p.Order == sectionData.Position.SectionIndex && p.LayoutIndex == sectionData.Position.LayoutIndex.Value).First();

// ZoneEmphasis on a vertical section column needs to be retained as that "overrides" the zone emphasis set on the section
Expand All @@ -1199,7 +1199,7 @@ private void LoadFromHtml(string html, string pageHeaderHtml)
}
else
{
currentSection.AddColumn(new CanvasColumn(currentSection, sectionData.Position.SectionIndex, sectionData.Position.SectionFactor));
currentSection.AddColumn(new CanvasColumn(currentSection, (int)sectionData.Position.SectionIndex, sectionData.Position.SectionFactor));
currentColumn = currentSection.Columns.Where(p => p.Order == sectionData.Position.SectionIndex).First();
}
}
Expand Down Expand Up @@ -1435,7 +1435,7 @@ private void ApplySectionAndColumn(CanvasControl control, CanvasControlPosition
{
if (position.LayoutIndex.HasValue)
{
(currentSection as CanvasSection).AddColumn(new CanvasColumn(currentSection as CanvasSection, position.SectionIndex, position.SectionFactor, position.LayoutIndex.Value));
(currentSection as CanvasSection).AddColumn(new CanvasColumn(currentSection as CanvasSection, (int)position.SectionIndex, position.SectionFactor, position.LayoutIndex.Value));
currentColumn = currentSection.Columns.Where(p => p.Order == position.SectionIndex && p.LayoutIndex == position.LayoutIndex.Value).First();

// ZoneEmphasis on a vertical section column needs to be retained as that "overrides" the zone emphasis set on the section
Expand All @@ -1446,7 +1446,7 @@ private void ApplySectionAndColumn(CanvasControl control, CanvasControlPosition
}
else
{
(currentSection as CanvasSection).AddColumn(new CanvasColumn(currentSection as CanvasSection, position.SectionIndex, position.SectionFactor));
(currentSection as CanvasSection).AddColumn(new CanvasColumn(currentSection as CanvasSection, (int)position.SectionIndex, position.SectionFactor));
currentColumn = currentSection.Columns.Where(p => p.Order == position.SectionIndex).First();
}
}
Expand Down