Skip to content

Conversation

@mloitzl
Copy link
Contributor

@mloitzl mloitzl commented Nov 24, 2023

set all sharePointAdminLoginNames for groupified sites
improve tests

Fixes #1307

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63545f3) 82.42% compared to head (41024c1) 81.56%.
Report is 1647 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1323      +/-   ##
==========================================
- Coverage   82.42%   81.56%   -0.86%     
==========================================
  Files         416      624     +208     
  Lines       28590    43467   +14877     
  Branches        0     4565    +4565     
==========================================
+ Hits        23565    35455   +11890     
- Misses       5025     6663    +1638     
- Partials        0     1349    +1349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansenbe
Copy link
Contributor

@mloitzl : travelling at the moment, will process this one as soon as possible. Thanks for sharing!

@jansenbe jansenbe merged commit 551df62 into pnp:dev Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SetSiteCollectionAdminsAsync does not consistently work for Groupified sites

3 participants