Skip to content

Conversation

@LeHailender
Copy link
Contributor

  • Ability to specify members on a modern group connected team site on creation time. Only applicable when you use Application permissions.
  • Corresponding unit test

@LeHailender LeHailender marked this pull request as ready for review October 1, 2022 12:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 82.42% // Head: 84.07% // Increases project coverage by +1.64% 🎉

Coverage data is based on head (20b8ac3) compared to base (63545f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #981      +/-   ##
==========================================
+ Coverage   82.42%   84.07%   +1.64%     
==========================================
  Files         416      600     +184     
  Lines       28590    40090   +11500     
==========================================
+ Hits        23565    33704   +10139     
- Misses       5025     6386    +1361     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamChatMessage.cs 72.34% <0.00%> (-27.66%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 84.69% <0.00%> (-15.31%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
...k/PnP.Core/Model/SharePoint/Core/Internal/Field.cs 80.18% <0.00%> (-12.68%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 57.14% <0.00%> (-10.76%) ⬇️
.../Model/SharePoint/Core/Internal/SharePointAdmin.cs 83.33% <0.00%> (-10.53%) ⬇️
... and 291 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jansenbe added a commit that referenced this pull request Oct 3, 2022
@jansenbe jansenbe merged commit 20b8ac3 into pnp:dev Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants