Conversation
Merged
Draft
KSXGitHub
pushed a commit
that referenced
this pull request
Apr 30, 2026
#1 (parse_shebang args leading whitespace): `splitn(2, [' ', '\t'])` discarded the whitespace separator, so an upstream-format `#!/bin/sh -e` parsed to `args="-e"` and the rendered shim text emitted one space between prog and the first flag where upstream emits two. Replace `splitn` with a manual `find([' ', '\t'])` + `split_at` that keeps the separator in the args slice, matching upstream's regex group `(.*)$`. Update `parses_direct_shebang` and `parses_env_dash_s_shebang` to assert the leading-space form so the regression direction is pinned. #2 (idempotent skip checked only `.sh` but skipped writes for all three): if a previous install wrote `.sh` correctly but `.cmd`/`.ps1` were missing — older pacquet, partial-write crash — `already_correct` short-circuited and the upgrade path never repaired the siblings. Gate `already_correct` on the `.sh` marker AND the existence of both `.cmd` and `.ps1`. Add `link_bins_rewrites_when_only_sh_flavor_exists` which deletes the two siblings and verifies the second `link_bins` pass re-creates them. Verified by re-breaking the gate temporarily and confirming the new test fails, then reverting. Findings 3, 4, 5, 9 are pending review acceptance; they'll land in a follow-up commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.