fix: store_dir envs should without $ symbols#21
Merged
Conversation
Member
|
Yes you are definitely right. Thank you! |
Member
|
The tests seems to be failing. |
Contributor
Author
Looks like old test case failed,not new. Seems like #14 
|
Member
|
@southorange0929 macos and linux tests are failing with the new added test as well. |
anonrig
approved these changes
Jul 21, 2023
Member
|
Nice catch! Thanks. |
Contributor
Author
|
Resolved test case, but windows platform i can't fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think env should without
$symbols.$just for us to use it with bash.For exampleIn rust , we should use it with these code: