Conversation
This was referenced Apr 24, 2026
Draft
KSXGitHub
pushed a commit
that referenced
this pull request
Apr 30, 2026
Applies review finding #3. The trait wraps `std::fs::write`, which is not atomic — `SIGINT` mid-write leaves a truncated file. Naming it `FsWriteAtomic` promised a guarantee the implementation does not deliver and would propagate to every downstream caller. Drop the misleading suffix. The trait documents explicitly that it inherits `std::fs::write`'s contract and nothing more. If a future caller needs atomic semantics (write-tempfile-then-rename), it should build that on top of `FsWrite` rather than hide the algorithm inside the capability — keeping the trait minimal lets every callsite see exactly what guarantees it inherits. Mechanical rename across the cmd-shim crate and the package-manager call sites; no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.