Skip to content

feat: add initial install command support#33

Merged
anonrig merged 6 commits intomainfrom
install-command
Jul 26, 2023
Merged

feat: add initial install command support#33
anonrig merged 6 commits intomainfrom
install-command

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Jul 25, 2023

Work in progress. Opening to receive feedback.

I'm not really happy with the architecture of the whole project and how registry sits on top of everything. Any recommendations @steveklabnik?

@anonrig anonrig requested a review from steveklabnik July 25, 2023 20:28
@metcoder95
Copy link
Copy Markdown

metcoder95 commented Jul 25, 2023

Keeping an eye on this as I also had a little bit of struggle thinking where to implement the list one 😅

@anonrig
Copy link
Copy Markdown
Member Author

anonrig commented Jul 25, 2023

Keeping an eye on this as I also had a little bit of struggle thinking where to implement the list one 😅

I'm planning on adding a package_manager crate and move most of the stuff from registry to there to have a single ownership.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #33 (6b4a3b2) into main (ff5e2d6) will increase coverage by 17.07%.
The diff coverage is 94.23%.

@@             Coverage Diff             @@
##             main      #33       +/-   ##
===========================================
+ Coverage   65.88%   82.96%   +17.07%     
===========================================
  Files          16       17        +1     
  Lines         850      939       +89     
===========================================
+ Hits          560      779      +219     
+ Misses        290      160      -130     
Files Changed Coverage Δ
crates/cli/src/lib.rs 60.41% <0.00%> (-4.03%) ⬇️
crates/registry/src/package.rs 100.00% <ø> (+29.21%) ⬆️
crates/cli/src/commands.rs 21.73% <25.00%> (+0.68%) ⬆️
crates/package_manager/src/lib.rs 88.88% <88.88%> (ø)
crates/registry/src/lib.rs 95.12% <93.93%> (+95.12%) ⬆️
crates/npmrc/src/lib.rs 94.82% <100.00%> (+0.09%) ⬆️
crates/package_json/src/lib.rs 95.34% <100.00%> (+0.11%) ⬆️
crates/package_manager/src/add.rs 100.00% <100.00%> (ø)
crates/package_manager/src/install.rs 100.00% <100.00%> (ø)

@anonrig anonrig merged commit a52375b into main Jul 26, 2023
@anonrig anonrig deleted the install-command branch July 26, 2023 15:09
@steveklabnik
Copy link
Copy Markdown
Collaborator

I'm not really happy with the architecture of the whole project and how registry sits on top of everything. Any recommendations @steveklabnik?

Hey sorry didn't have a ton of time to look at this until now. Was this question purely about this PR, or about the project as a whole?

@anonrig
Copy link
Copy Markdown
Member Author

anonrig commented Jul 27, 2023

I'm not really happy with the architecture of the whole project and how registry sits on top of everything. Any recommendations @steveklabnik?

Hey sorry didn't have a ton of time to look at this until now. Was this question purely about this PR, or about the project as a whole?

No worries. It was a more generic question than specifically for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants