docs(settings): Drop react-native note from hoisted docs#774
Open
docs(settings): Drop react-native note from hoisted docs#774
hoisted docs#774Conversation
|
|
|
@kitten is attempting to deploy a commit to the pnpm Team on Vercel. A member of the Team first needs to authorize it. |
|
To also provide some historical context: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to drop the "A React Native project will most probably only work if you use a hoisted
node_modules."There's a bit of nuance to this, because not all React Native projects are the same or set up the same. That said, one recommendation is to use a framework, e.g. Expo: https://reactnative.dev/docs/environment-setup
While I can't vouch for all React Native dependencies and setups to be isolated-safe, at Expo, we've actively worked on this and now support and guarantee that isolated installations work. In fact, we're looking to move this to be the default recommendation for pnpm gradually. We've also in the meantime have started switching the
expo/expomonorepo to use pnpm in isolated mode as well.There's kind of a longer story to this, some of which I've written about in my blog post, but as a direct consequence, I'd love to see:
Cheers!