Fixes for SwiftSyntax 601 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Apr 3, 2025
Comment on lines
+76
to
+94
| let successReturnType: TypeSyntax? = { | ||
| guard isResultReturn | ||
| else { return returnType } | ||
|
|
||
| let successType = returnType!.as(IdentifierTypeSyntax.self)!.genericArgumentClause?.arguments.first! | ||
| .argument | ||
| #if canImport(SwiftSyntax601) | ||
| switch successType { | ||
| case .none: | ||
| return nil | ||
| case .type(let syntax): | ||
| return syntax | ||
| default: | ||
| return nil | ||
| } | ||
| #else | ||
| return successType | ||
| #endif | ||
| }() |
There was a problem hiding this comment.
I didn't spend a ton of time coming up with the nicest way to support SwiftSyntax 601 for this because it's just a test.
stephencelis
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftSyntax 601 has some breaking changes from SwiftSyntax 600 that affected this library and so we need to do a little work to support all versions of SwiftSyntax.