Implement lobby leave functionality #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenbollen
reviewed
Jul 7, 2025
erikdubbelboer
force-pushed
the
codex/determine-priority-for-lobby-functionality
branch
from
a571dd6 to
3df6a8a
Compare
erikdubbelboer
force-pushed
the
codex/determine-priority-for-lobby-functionality
branch
from
c34ffa0 to
2374d32
Compare
koenbollen
approved these changes
Jul 8, 2025
internal/signaling/types.go
Outdated
| @@ -94,6 +94,16 @@ type LobbyUpdatedPacket struct { | |||
| LobbyInfo stores.Lobby `json:"lobbyInfo"` | |||
| } | |||
|
|
|||
| type LeaveLobbyPacket struct { | |||
There was a problem hiding this comment.
nitpick: The "Lobby" part could go here
internal/signaling/types.go
Outdated
| Type string `json:"type"` | ||
| } | ||
|
|
||
| type LeftLobbyPacket struct { |
There was a problem hiding this comment.
nitpick: the "Lobby" part could go here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
leave()in Network APIleaveevents from signalingleaveLobbypacket on serverTesting
go test ./...yarn cucumber(fails: cucumber-js not found)https://chatgpt.com/codex/tasks/task_e_6867d29d6d448320bb7eea6347085ce3